Hi, These are the same changes I send earlier in two parts against 2.6.0-test1. I remade the diff against 2.6.0-test3 as Stephen Hemminger's patch clashed with mine (My patch already had the fix....)
You lost a critical fix to ax25; it oop's if I bring up any device then do "ifconfig -a" due to use after free. PLEASE do some debugging with some of the kernel debugging options enabled! Uninitialis
It looks like af_x25 is advertising itself as a new style protocol, yet if I walk the receive path: ax25_kiss_rcv -> ax25_rcv -> ax25_addr_parse there is no place that checks that the address portion
Which fix exactly did I miss? the only thing I see in your patch is the change to use sock_put in ax25_destroy_sock() and that was in my original patch... btw, I do have debugging enabled... Jeroen
Since at the moment the only zero-copy path I can imagine is from packets over a bpq ethernet device wouldn't it be the easiest to just check at ax25_rcv() for non-linear packets and call skb_lineari
skb_linearize() is a deprecated interface, no new pieces of code should use it. If you want to mark the protocol as a new one you must do the non-linear handling properly just like every other protoc