Any chance we can get this patch in? It's been out for exactly 4 month in it's final reviewed form, and I still have patches that I rebased on top of it waiting.. --end quoted text--
Any chance we can get this patch in? It's been out for exactly 4 month in it's final reviewed form, and I still have patches that I rebased on top of it waiting.. --end quoted text--
i_gen is incremented in directory operations when the directory is changed. It is never read or otherwise used so it should be removed to help reduce the size of the struct xfs_inode. The patch also
i_gen is incremented in directory operations when the directory is changed. It is never read or otherwise used so it should be removed to help reduce the size of the struct xfs_inode. The patch also
i_gen is incremented in directory operations when the directory is changed. It is never read or otherwise used so it should be removed to help reduce the size of the struct xfs_inode. The patch also
Still looks as good as when you posted it first month ago :) And for reference here's the required fixup for xfsidbg: Index: linux-2.6-xfs/fs/xfs/xfsidbg.c == -- linux-2.6-xfs.orig/fs/xfs/xfsidbg.c 2
i_gen is incremented in directory operations when the directory is changed. It is never read or otherwise used so it should be removed to help reduce the size of the struct xfs_inode. Signed-off-by:
It also removes a xfs_trans_log_inode in xfs_remove, which looks fine to me from a quick glance, but this should be verified and documented. Otherwise looks good.
If you note in the very next if/else statement the directory inode gets logged - either by dropping the link or directly. IOWs, we were logging the directory inode twice with the same value (XFS_ILOG
Updated patch below. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx XFS: remove i_gen from incore inode i_gen is incremented in directory operations when the directory is changed. It is never read