Applied, to 2.4.x and 2.6.x, thanks Thomas. This issue comes up again and again. In the most recent discussion I remember partaking in, I was trying to get it so that all the code paths would calcula
Furthermore, it's not sk_buff that's ever the issue. The SKB data area size is where the skb_shared_info gets tacked onto, sk_buff's size is never added to this calculation.
I don't understand, if we alloc_skb(copy) we are guarenteed to have "copy" bytes available in the SKB data area. This transformation to SKB_MAX_ORDER() (with the "+ 31" removed as per Alexey's reply)
Yes but don't we waste space in the headroom of the new skb iff the headroom of the original skb is no aligned to SKB_DATA_ALIGN? I'll post a new patch without the anyway though.
Applied, to 2.4.x and 2.6.x, thanks Thomas. This issue comes up again and again. In the most recent discussion I remember partaking in, I was trying to get it so that all the code paths would calcula
Furthermore, it's not sk_buff that's ever the issue. The SKB data area size is where the skb_shared_info gets tacked onto, sk_buff's size is never added to this calculation.
I don't understand, if we alloc_skb(copy) we are guarenteed to have "copy" bytes available in the SKB data area. This transformation to SKB_MAX_ORDER() (with the "+ 31" removed as per Alexey's reply)
Yes but don't we waste space in the headroom of the new skb iff the headroom of the original skb is no aligned to SKB_DATA_ALIGN? I'll post a new patch without the anyway though.