AFAIU, there is a race condition in multipath_drr code, these code paths try to access & change last_selection variable without any synchronization. Please correct me if I am wrong. Code Path - 1 __
Yes you're right. You don't need all this code. All you need to do is do result = last_selection before the if condition and then check result in the if condition instead of last_selection. The multi
Herbert Xu wrote: On Mon, May 23, 2005 at 05:56:39PM +0530, pravin wrote: /* if necessary and possible utilize the old alternative */ - if ((flp->flags & FLOWI_FLAG_MULTIPATHOLDROUTE) != 0 && - last_
Indeed. In fact this whole MULTIPATHOLDROUTE thing can't possibly work at all. I'd suggest that it be removed. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herb
Herbert Xu wrote: On Tue, May 24, 2005 at 12:16:38PM +0530, pravin b shelar wrote: In fact this whole MULTIPATHOLDROUTE thing can't possibly work at all. I'd suggest that it be removed. So I think we
hi AFAIU, there is a race condition in multipath_drr code, these code paths try to access & change last_selection variable without any synchronization. Please correct me if I am wrong. Code Path - 1
Yes you're right. You don't need all this code. All you need to do is do result = last_selection before the if condition and then check result in the if condition instead of last_selection. The multi
/* if necessary and possible utilize the old alternative */ - if ((flp->flags & FLOWI_FLAG_MULTIPATHOLDROUTE) != 0 && - last_selection != NULL) { - result = last_selection; - *rp = result; - return;
Indeed. In fact this whole MULTIPATHOLDROUTE thing can't possibly work at all. I'd suggest that it be removed. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herb
In fact this whole MULTIPATHOLDROUTE thing can't possibly work at all. I'd suggest that it be removed. So I think we should ignore MULTIPATHOLDROUTE flag in drr and rr multipath algorithms as done i