Adrian Bunk wrote: + select CRYPTO select CRYPTO_AES --help-- Include software based cipher suites in support of IEEE 802.11i (aka TGi, WPA, WPA2, WPA-PSK, etc.) for use with CCMP enabled networks. @
Adrian Bunk wrote: On Wed, Mar 02, 2005 at 01:43:04AM -0500, Jeff Garzik wrote: Adrian Bunk wrote: + select CRYPTO select CRYPTO_AES --help-- Include software based cipher suites in support of IEEE 8
Thing is, CRYPTO_AES on only selectable on x86. So really, IEEE80211_CRYPT_CCMP should depend upon CRYPTO_AES rather than selecting it. But that confuses users.
Andrew Morton wrote: Jeff Garzik <jgarzik@xxxxxxxxx> wrote: Adrian Bunk wrote: On Wed, Mar 02, 2005 at 01:43:04AM -0500, Jeff Garzik wrote: Adrian Bunk wrote: + select CRYPTO select CRYPTO_AES --help
That's pretty broken, isn't it? Would be better to just do: config CRYPTO_AES select CRYPTO_AES_586 if (X86 && !X86_64) select CRYPTO_AES_OTHER if !(X86 && !X86_64) and hide CRYPTO_AES_586 and CRYPTO
Exactly. And if CRYPTO_AES would select CRYPTO, you'd have a recursive dependency. The only possible thing would be to change all dependencies on CRYPTO to selects. This wouldn't be unlogical since t
Andrew Morton wrote: Jeff Garzik <jgarzik@xxxxxxxxx> wrote: Thing is, CRYPTO_AES on only selectable on x86. You're thinking about CRYPTO_AES_586. But looking at crypto/Kconfig, the dependencies are a
Adrian Bunk wrote: On Wed, Mar 02, 2005 at 05:41:50PM -0500, Jeff Garzik wrote: Andrew Morton wrote: Jeff Garzik <jgarzik@xxxxxxxxx> wrote: Thing is, CRYPTO_AES on only selectable on x86. You're thin
Some of the options that needlessly wrote in their help text which options they do selct (patch already sent) didn't obey the most important rule of select If you select something, you have to ensure
Adrian Bunk wrote: + select CRYPTO select CRYPTO_AES --help-- Include software based cipher suites in support of IEEE 802.11i (aka TGi, WPA, WPA2, WPA-PSK, etc.) for use with CCMP enabled networks. @
+ select CRYPTO select CRYPTO_AES --help-- Include software based cipher suites in support of IEEE 802.11i (aka TGi, WPA, WPA2, WPA-PSK, etc.) for use with CCMP enabled networks. @@ -54,10 +55,11 @@
Thing is, CRYPTO_AES on only selectable on x86. So really, IEEE80211_CRYPT_CCMP should depend upon CRYPTO_AES rather than selecting it. But that confuses users.
+ select CRYPTO select CRYPTO_AES --help-- Include software based cipher suites in support of IEEE 802.11i (aka TGi, WPA, WPA2, WPA-PSK, etc.) for use with CCMP enabled networks. @@ -54,10 +55,11 @@
That's pretty broken, isn't it? Would be better to just do: config CRYPTO_AES select CRYPTO_AES_586 if (X86 && !X86_64) select CRYPTO_AES_OTHER if !(X86 && !X86_64) and hide CRYPTO_AES_586 and CRYPTO