Hello, Here is the v2 patch for fixing ASSERTION failed at xfs_vm_write_failed() according to Dave's comments, so I added Dave as SOB for credit. Hi Michael, Please kindly try at your at your conveni
Looks good in limited testing. I set some extra debug code somewhere, causing every failed mount in xfstests #078 to show up, so the original test cases were double-checked, both on the main partitio
No, please don't add my SOB to a patch you wrote, even if I came up with the idea of how to do something. A SOB indicates that someone has verified the origin of the patch (e.g. for copyright reasons
Ah, got it! :-P. Indeed, the patch is improved as following: In xfs_vm_write_failed(), we evaluate the block_offset of pos with PAGE_MASK which is 0xfffff000 as an unsigned long, that is fine on 64-b
That's the 32 bit value. if it's a 64 bit value, it's 0xfffffffffffff000. So I'd just rearrange this slightly: ... Saying we are clearing the lower 12 bits is not technically correct, as there are pl
Thanks Dave for correcting me with detailed comments, the revised patch was shown as following. Regards, -Jeff In xfs_vm_write_failed(), we evaluate the block_offset of pos with PAGE_MASK which is an
Reviewed-by: Dave Chinner<dchinner@xxxxxxxxxx> Thanks Dave for correcting me with detailed comments, the revised patch was shown as following. Regards, -Jeff In xfs_vm_write_failed(), we evaluate the