older xfs_io refused to write to /dev/null because it's not a file on an xfs filesystem. So add -F. While we're at it, add more testcases: * symlink on a RO fs pointing to a file on a RW fs. * bind-m
You could just do: export XFS_IO_PROG="$XFS_IO_PROG -F" and not have to change so much of the test. And with a comment it would make it obvious to a future ready why the -F flag is used ;) Cheers, Da
Well, it's not just this test; it's any non-xfs-specific test which uses xfs_io for anything at all. We have -F's sprinkled through many tests for that reason, even though -F is deprecated upstream.
OK, sounds like we should detect if it is needed when setting up XFS_IO_PROG in common/config rather than changing every test.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
It's just these 2 for now; I'd like to see if we can go ahead & merge this as is and I'll follow up with something to change over every non-xfs-specific test to DTRT, ok? Thanks, -Eric