Search String: Display: Description: Sort:

Results:

References: [ +subject:/^(?:^\s*(re|sv|fwd|fw)[\[\]\d]*[:>-]+\s*)*\[PATCH\s+V2\]\s+xfs_repair\:\s+skip\s+freelist\s+scan\s+of\s+corrupt\s+agf\s+in\s+no\-modify\s+mode\s*$/: 7 ]

Total 7 documents matching your query.

1. [PATCH V2] xfs_repair: skip freelist scan of corrupt agf in no-modify mode (score: 1)
Author: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sat, 02 Mar 2013 15:23:12 -0600
In xfs_repair's no-modify mode (-n), verify_set_agf doesn't fix up bad freelist blocks that it finds. When we get to scan_freelist, this can wreak havoc if, for example, first > last and the loop nev
/archives/xfs/2013-03/msg00040.html (9,247 bytes)

2. Re: [PATCH V2] xfs_repair: skip freelist scan of corrupt agf in no-modify mode (score: 1)
Author: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 4 Mar 2013 10:36:15 +1100
Looks ok, but IIRC there are overruns in these functions for the same reason (i.e. unchecked use of agf->agf_flfirst as an array index) db/check.c::scan_freelist() db/freesp.c::scan_freelist() I foun
/archives/xfs/2013-03/msg00057.html (10,695 bytes)

3. Re: [PATCH V2] xfs_repair: skip freelist scan of corrupt agf in no-modify mode (score: 1)
Author: Rich Johnston <rjohnston@xxxxxxx>
Date: Fri, 8 Mar 2013 14:31:23 -0600
This version looks good. ;) Reviewed-by: Rich Johnston <rjohnston@xxxxxxx> This has been committed. xfsprogs: xfs_repair skip freelist scan of corrupt agf in no-modify mode In xfs_repair's no-modify
/archives/xfs/2013-03/msg00208.html (9,386 bytes)

4. Re: [PATCH V2] xfs_repair: skip freelist scan of corrupt agf in no-modify mode (score: 1)
Author: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 08 Mar 2013 14:31:51 -0600
Thanks; from what Dave said there are probably other spots that need love as well. -Eric
/archives/xfs/2013-03/msg00209.html (9,819 bytes)

5. Re: [PATCH V2] xfs_repair: skip freelist scan of corrupt agf in no-modify mode (score: 1)
Author: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sat, 9 Mar 2013 20:00:41 +1100
Except that all review comments have not been addressed. i.e there are two places that have the same bug and they haven't been fixed. It's great that you want to commit quickly, but commits should no
/archives/xfs/2013-03/msg00216.html (9,412 bytes)

6. Re: [PATCH V2] xfs_repair: skip freelist scan of corrupt agf in no-modify mode (score: 1)
Author: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sat, 09 Mar 2013 09:00:55 -0600
Actually it's not quite: scan.c: In function scan_freelist: scan.c:1074: warning: i may be used uninitialized in this function I don't know what's wrong with my brain these days. :/ I will send a pat
/archives/xfs/2013-03/msg00218.html (10,583 bytes)

7. Re: [PATCH V2] xfs_repair: skip freelist scan of corrupt agf in no-modify mode (score: 1)
Author: Rich Johnston <rjohnston@xxxxxxx>
Date: Mon, 11 Mar 2013 07:20:35 -0500
Reviewed-by: Rich Johnston <rjohnston@xxxxxxx> This has been committed. Except that all review comments have not been addressed. i.e there are two places that have the same bug and they haven't been
/archives/xfs/2013-03/msg00254.html (10,758 bytes)


This search system is powered by Namazu