In xfs_repair's no-modify mode (-n), verify_set_agf doesn't fix up bad freelist blocks that it finds. When we get to scan_freelist, this can wreak havoc if, for example, first > last and the loop nev
Looks ok, but IIRC there are overruns in these functions for the same reason (i.e. unchecked use of agf->agf_flfirst as an array index) db/check.c::scan_freelist() db/freesp.c::scan_freelist() I foun
This version looks good. ;) Reviewed-by: Rich Johnston <rjohnston@xxxxxxx> This has been committed. xfsprogs: xfs_repair skip freelist scan of corrupt agf in no-modify mode In xfs_repair's no-modify
Except that all review comments have not been addressed. i.e there are two places that have the same bug and they haven't been fixed. It's great that you want to commit quickly, but commits should no
Actually it's not quite: scan.c: In function scan_freelist: scan.c:1074: warning: i may be used uninitialized in this function I don't know what's wrong with my brain these days. :/ I will send a pat
Reviewed-by: Rich Johnston <rjohnston@xxxxxxx> This has been committed. Except that all review comments have not been addressed. i.e there are two places that have the same bug and they haven't been