I encountered the following panic when using xfs partitions as rootfs, which is due to the truncated log data read by xlog_bread_noalign(). We should extend the buffer by one extra log sector to ensu
Hi Tony, Looks fine to me. I'll pull it in after some testing. Do you happen to have a metadump of this filesystem? Reviewed-by: Ben Myers <bpm@xxxxxxx> Thanks! -Ben
We've never done that round up in xlog_bread_noalign(). It shouldn't be necessary as xlog_get_bp() and xlog_bread_noalign() are doing fundamentally different things. That is, xlog_get_bp() is ensurin
I set the sector size as 4096 when making the xfs filesystem. -sh-4.1# mkfs.xfs -s size=4096 -f /dev/sda3 In this case, xlog_bread_noalign() needs to do such round up and round down frequently. And
Sorry I did not keep the metadump of it. But I kept some debugging info when I debugged and fixed it a year ago. Starting XFS recovery on filesystem: ram0 (logdev: internal) xlog_bread_noalign--befo
..... If you have a 4k sector device, then the log sector size is the same as the physical device. Hence the log code assumes that if you have a specific log sector size, it is operating on a device
I am not sure about this, since I saw many reads on non-sector-align blocks even when successfully mounting good XFS partitions. -sh-4.1# mount /dev/sda3 /home/ XFS (sda3): Mounting Filesystem xlog_
I didn't say that non-sector align reads should not be attempted by log recovery - it's obvious from the on disk format of the log that we have to parse it in chunks of 512 bytes to make sense of it'
I get a reliable way to reproduce this bug. The logprint and metadump are attached. Kernel version: 2.6.38.8 Mkfs.xfs version: xfsprogs-3.1.1 mkfs.xfs -s size=4096 /dev/sda1 Run the following mount-c
This is important.... .... .... because this: Indicates that the unmount record is either not being written, it is being written when there log has not been fully flushed or log recovery is not findi
Kernel version: 2.6.38.8 Mkfs.xfs version: xfsprogs-3.1.1 mkfs.xfs -s size=4096 /dev/sda1 Run the following mount-cp-umount script to reproduce: device=/dev/sda1 mount_point=/mnt times=10 for ((num=1
Kernel version: 2.6.38.8 Mkfs.xfs version: xfsprogs-3.1.1 mkfs.xfs -s size=4096 /dev/sda1 Run the following mount-cp-umount script to reproduce: device=/dev/sda1 mount_point=/mnt times=10 for ((num=1
Thanks for you following up. My apologize that I just found that it is one change I made before that causes this problem. This change forces mkfs.xfs to format xfs partitions whose sectorsize were no
You do realise that bug doesn't affect x86-64 platforms as they don't support 64k pages? Neither do I, and I don't care to look any further because the problem is of your own making. In future, pleas