Search String: Display: Description: Sort:

Results:

References: [ +subject:/^(?:^\s*(re|sv|fwd|fw)[\[\]\d]*[:>-]+\s*)*\[PATCH\]\s+xfs\:\s+Fix\s+possible\s+truncation\s+of\s+log\s+data\s+in\s+xlog_bread_noalign\(\)\s*$/: 14 ]

Total 14 documents matching your query.

1. [PATCH] xfs: Fix possible truncation of log data in xlog_bread_noalign() (score: 1)
Author: Tony Lu <zlu@xxxxxxxxxx>
Date: Fri, 22 Feb 2013 08:12:52 +0000
I encountered the following panic when using xfs partitions as rootfs, which is due to the truncated log data read by xlog_bread_noalign(). We should extend the buffer by one extra log sector to ensu
/archives/xfs/2013-02/msg00404.html (11,029 bytes)

2. Re: [PATCH] xfs: Fix possible truncation of log data in xlog_bread_noalign() (score: 1)
Author: Ben Myers <bpm@xxxxxxx>
Date: Fri, 22 Feb 2013 13:14:26 -0600
Hi Tony, Looks fine to me. I'll pull it in after some testing. Do you happen to have a metadump of this filesystem? Reviewed-by: Ben Myers <bpm@xxxxxxx> Thanks! -Ben
/archives/xfs/2013-02/msg00417.html (10,955 bytes)

3. Re: [PATCH] xfs: Fix possible truncation of log data in xlog_bread_noalign() (score: 1)
Author: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sat, 23 Feb 2013 11:08:02 +1100
We've never done that round up in xlog_bread_noalign(). It shouldn't be necessary as xlog_get_bp() and xlog_bread_noalign() are doing fundamentally different things. That is, xlog_get_bp() is ensurin
/archives/xfs/2013-02/msg00423.html (11,557 bytes)

4. RE: [PATCH] xfs: Fix possible truncation of log data in xlog_bread_noalign() (score: 1)
Author: Tony Lu <zlu@xxxxxxxxxx>
Date: Sat, 23 Feb 2013 07:06:10 +0000
I set the sector size as 4096 when making the xfs filesystem. -sh-4.1# mkfs.xfs -s size=4096 -f /dev/sda3 In this case, xlog_bread_noalign() needs to do such round up and round down frequently. And
/archives/xfs/2013-02/msg00432.html (15,916 bytes)

5. RE: [PATCH] xfs: Fix possible truncation of log data in xlog_bread_noalign() (score: 1)
Author: Tony Lu <zlu@xxxxxxxxxx>
Date: Sat, 23 Feb 2013 08:32:09 +0000
Sorry I did not keep the metadump of it. But I kept some debugging info when I debugged and fixed it a year ago. Starting XFS recovery on filesystem: ram0 (logdev: internal) xlog_bread_noalign--befo
/archives/xfs/2013-02/msg00433.html (15,011 bytes)

6. Re: [PATCH] xfs: Fix possible truncation of log data in xlog_bread_noalign() (score: 1)
Author: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sun, 24 Feb 2013 10:55:46 +1100
..... If you have a 4k sector device, then the log sector size is the same as the physical device. Hence the log code assumes that if you have a specific log sector size, it is operating on a device
/archives/xfs/2013-02/msg00435.html (15,479 bytes)

7. RE: [PATCH] xfs: Fix possible truncation of log data in xlog_bread_noalign() (score: 1)
Author: Tony Lu <zlu@xxxxxxxxxx>
Date: Sun, 24 Feb 2013 04:46:30 +0000
I am not sure about this, since I saw many reads on non-sector-align blocks even when successfully mounting good XFS partitions. -sh-4.1# mount /dev/sda3 /home/ XFS (sda3): Mounting Filesystem xlog_
/archives/xfs/2013-02/msg00436.html (12,035 bytes)

8. Re: [PATCH] xfs: Fix possible truncation of log data in xlog_bread_noalign() (score: 1)
Author: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 25 Feb 2013 01:10:17 +1100
I didn't say that non-sector align reads should not be attempted by log recovery - it's obvious from the on disk format of the log that we have to parse it in chunks of 512 bytes to make sense of it'
/archives/xfs/2013-02/msg00438.html (11,801 bytes)

9. RE: [PATCH] xfs: Fix possible truncation of log data in xlog_bread_noalign() (score: 1)
Author: Tony Lu <zlu@xxxxxxxxxx>
Date: Tue, 26 Feb 2013 07:28:19 +0000
I get a reliable way to reproduce this bug. The logprint and metadump are attached. Kernel version: 2.6.38.8 Mkfs.xfs version: xfsprogs-3.1.1 mkfs.xfs -s size=4096 /dev/sda1 Run the following mount-c
/archives/xfs/2013-02/msg00491.html (15,981 bytes)

10. Re: [PATCH] xfs: Fix possible truncation of log data in xlog_bread_noalign() (score: 1)
Author: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 27 Feb 2013 07:52:41 +1100
This is important.... .... .... because this: Indicates that the unmount record is either not being written, it is being written when there log has not been fully flushed or log recovery is not findi
/archives/xfs/2013-02/msg00501.html (12,368 bytes)

11. Re: [PATCH] xfs: Fix possible truncation of log data in xlog_bread_noalign() (score: 1)
Author: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 01 Mar 2013 09:51:58 -0600
Kernel version: 2.6.38.8 Mkfs.xfs version: xfsprogs-3.1.1 mkfs.xfs -s size=4096 /dev/sda1 Run the following mount-cp-umount script to reproduce: device=/dev/sda1 mount_point=/mnt times=10 for ((num=1
/archives/xfs/2013-03/msg00014.html (12,163 bytes)

12. Re: [PATCH] xfs: Fix possible truncation of log data in xlog_bread_noalign() (score: 1)
Author: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 01 Mar 2013 14:24:26 -0600
Kernel version: 2.6.38.8 Mkfs.xfs version: xfsprogs-3.1.1 mkfs.xfs -s size=4096 /dev/sda1 Run the following mount-cp-umount script to reproduce: device=/dev/sda1 mount_point=/mnt times=10 for ((num=1
/archives/xfs/2013-03/msg00023.html (13,150 bytes)

13. RE: [PATCH] xfs: Fix possible truncation of log data in xlog_bread_noalign() (score: 1)
Author: Tony Lu <zlu@xxxxxxxxxx>
Date: Mon, 4 Mar 2013 08:32:45 +0000
Thanks for you following up. My apologize that I just found that it is one change I made before that causes this problem. This change forces mkfs.xfs to format xfs partitions whose sectorsize were no
/archives/xfs/2013-03/msg00064.html (17,125 bytes)

14. Re: [PATCH] xfs: Fix possible truncation of log data in xlog_bread_noalign() (score: 1)
Author: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 5 Mar 2013 08:03:11 +1100
You do realise that bug doesn't affect x86-64 platforms as they don't support 64k pages? Neither do I, and I don't care to look any further because the problem is of your own making. In future, pleas
/archives/xfs/2013-03/msg00080.html (11,731 bytes)


This search system is powered by Namazu