xfs-masters
[Top] [All Lists]

[xfs-masters] Re: freeze vs freezer

To: "Rafael J. Wysocki" <rjw@xxxxxxx>
Subject: [xfs-masters] Re: freeze vs freezer
From: Elias Oltmanns <eo@xxxxxxxxxxxxxx>
Date: Tue, 01 Jul 2008 17:05:29 +0200
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs-masters@xxxxxxxxxxx, Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>, Kyle Moffett <mrmacman_g4@xxxxxxx>, Matthew Garrett <mjg59@xxxxxxxxxxxxx>, David Chinner <dgc@xxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Jens Axboe <jens.axboe@xxxxxxxxxx>
References: <4744FD87.7010301@goop.org> <200807010038.43362.rjw@sisk.pl> <20080701063835.GQ29319@disturbed> <200807011635.44696.rjw@sisk.pl>
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
User-agent: Gnus/5.110007 (No Gnus v0.7)
"Rafael J. Wysocki" <rjw@xxxxxxx> wrote:
> On Tuesday, 1 of July 2008, Dave Chinner wrote:
>> On Tue, Jul 01, 2008 at 12:38:41AM +0200, Rafael J. Wysocki wrote:
>
>> > On Tuesday, 1 of July 2008, Dave Chinner wrote:
>> > > On Mon, Jun 30, 2008 at 11:00:43PM +0200, Rafael J. Wysocki wrote:
>> > > > On Monday, 30 of June 2008, Dave Chinner wrote:
[...]
>> > > > > What do you do with a sync I/O (read or write)? The 
>> > > > > process is going to have to go to sleep somewhere in D state waiting
>> > > > > for that I/O to complete.  If you're going to intercept such
>> > > > > processes somewhere else to do something magic, then why not put
>> > > > > that magic in vfs_check_frozen()?
>> > > > 
>> > > > This might work too, but it would be nice to do something independent 
>> > > > of the
>> > > > freezer, so that we can drop the freezer when we want and not when we 
>> > > > are
>> > > > forced to.
>> > > 
>> > > vfs_check_frozen() is completely independent of the process freezer.
>> > 
>> > Well, can you please tell me how exactly that works, then?
>> 
>> Try looking at the code. When we freeze a filesystem sb->s_frozen
>> changes state depending on the level of freeze currently obtained
>> by the filesystem. And:
>> 
>> #define vfs_check_frozen(sb, level) \
>>         wait_event((sb)->s_wait_unfrozen, ((sb)->s_frozen < (level)))
>> 
>> Pretty bloody simple, really.
>
> OK
>
> Do all of the filesystems implement the freezing?

There is some work in progress [1]. If you think this will help you to
address this issue on the fs level, where I think it should be done, you
may even be able to request some changes to fit your needs before it
gets merged into mainline.

Regards,

Elias

[1] http://permalink.gmane.org/gmane.linux.file-systems/24716


<Prev in Thread] Current Thread [Next in Thread>