*From: *MAILER-DAEMON@xxxxxxx <mailto:MAILER-DAEMON@xxxxxxx> (Mail
Delivery System)
*Date: *January 21, 2009 6:26:47 PM CST
*To: *felixb@xxxxxxx <mailto:felixb@xxxxxxx>
*Subject: **Undelivered Mail Returned to Sender*
This is the Postfix program at host estes.americas.sgi.com.
I'm sorry to have to inform you that your message could not be
be delivered to one or more recipients. It's attached below.
For further assistance, please send mail to <postmaster>
If you do so, please include this problem report. You can
delete your own text from the attached returned message.
The Postfix program
<xfs@xxxxxxxxxxx <mailto:xfs@xxxxxxxxxxx>>: host
relay.sgi.com[137.38.102.111] said: 550 5.1.1
<xfs@xxxxxxxxxxx <mailto:xfs@xxxxxxxxxxx>>: Recipient address
rejected: undeliverable address: host
oss.sgi.com[192.48.182.195] said: 550 5.1.1 <xfs@xxxxxxxxxxx
<mailto:xfs@xxxxxxxxxxx>>... User
unknown (in reply to RCPT TO command) (in reply to RCPT TO command)
Reporting-MTA: dns; estes.americas.sgi.com
X-Postfix-Queue-ID: 5F007700016A
X-Postfix-Sender: rfc822; felixb@xxxxxxx <mailto:felixb@xxxxxxx>
Arrival-Date: Wed, 21 Jan 2009 18:26:44 -0600 (CST)
Final-Recipient: rfc822; xfs@xxxxxxxxxxx <mailto:xfs@xxxxxxxxxxx>
Action: failed
Status: 5.0.0
Diagnostic-Code: X-Postfix; host relay.sgi.com[137.38.102.111] said:
550 5.1.1
<xfs@xxxxxxxxxxx <mailto:xfs@xxxxxxxxxxx>>: Recipient address
rejected: undeliverable address: host
oss.sgi.com[192.48.182.195] said: 550 5.1.1 <xfs@xxxxxxxxxxx
<mailto:xfs@xxxxxxxxxxx>>... User
unknown (in reply to RCPT TO command) (in reply to RCPT TO command)
*From: *Felix Blyakher <felixb@xxxxxxx <mailto:felixb@xxxxxxx>>
*Date: *January 21, 2009 6:26:44 PM CST
*To: *Felix Blyakher <felixb@xxxxxxx <mailto:felixb@xxxxxxx>>
*Cc: *xfs@xxxxxxxxxxx <mailto:xfs@xxxxxxxxxxx>
*Subject: **Re: [PATCH] [XFS] Warn on transaction in flight on
read-only remount*
Just wanted to point out to discussion on this topic:
http://oss.sgi.com/archives/xfs/2008-12/msg00019.html
I merely took a suggestion from it, and put it in a patch.
Felix
On Jan 21, 2009, at 4:57 PM, Felix Blyakher wrote:
Till VFS can correctly support read-only remount without racing,
use WARN_ON instead of BUG_ON on detecting transaction in flight
after quiescing filesystem.
Signed-off-by: Felix Blyakher <felixb@xxxxxxx>
---
fs/xfs/linux-2.6/xfs_sync.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/fs/xfs/linux-2.6/xfs_sync.c b/fs/xfs/linux-2.6/xfs_sync.c
index 2ed0353..d8373ee 100644
--- a/fs/xfs/linux-2.6/xfs_sync.c
+++ b/fs/xfs/linux-2.6/xfs_sync.c
@@ -371,7 +371,10 @@ xfs_quiesce_attr(
/* flush inodes and push all remaining buffers out to disk */
xfs_quiesce_fs(mp);
- ASSERT_ALWAYS(atomic_read(&mp->m_active_trans) == 0);
+ /* Just warn here till VFS can correctly support
+ * read-only remount without racing.
+ */
+ WARN_ON(atomic_read(&mp->m_active_trans) == 0);
/* Push the superblock and write an unmount record */
error = xfs_log_sbcount(mp, 1);
--
1.6.1