[xfs-masters] Re: [PATCH] - remove local random function, use lib/random.c random32()

[Eric Sandeen <sandeen@xxxxxxxxxxx>]

Joe Perches wrote:
> reducing the number of random number functions
> 
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>

Looks good to me; since this is utilizing linux symbols in core xfs 
code, I might move the #include glue into xfs_linux.h rather than 
support.h, but that's nitpicking.  I'll let the sgi guys decide on that...

Good catch!

-Eric

> diff --git a/fs/xfs/support/debug.c b/fs/xfs/support/debug.c
> index 4363512..200b701 100644
> --- a/fs/xfs/support/debug.c
> +++ b/fs/xfs/support/debug.c
> @@ -78,20 +78,3 @@ assfail(char *expr, char *file, int line)
>       printk("Assertion failed: %s, file: %s, line: %d\n", expr, file, line);
>       BUG();
>  }
> -
> -#if ((defined(DEBUG) || defined(INDUCE_IO_ERRROR)) && 
> !defined(NO_WANT_RANDOM))
> -unsigned long random(void)

...