Junfeng Yang wrote:
>
>>>I suspect what you are doing with this change is making repair fail
>>>in the middle of creating the lost+found dir, repair always does that.
>>>
>
>
> Hi Steve,
>
> you mean xfs_repair creates lost+found everytime it runs? I'm not sure if
> the crash happens in the middling of creating lost+found, as our checker
> only sees block writes with little file system knowledge. We caught this
> warning automatically (w/o chaing the xfs_repair code).
>
> so is it true that in the rare case that xfs_repair fails in the middle of
> creating lost+found, '/.' can be wiped off? do you guys consider this as
> a bug?
Well, I don't work on xfs anymore really, I just watch from the sidelines.
It is a pretty small window in reality, but it probably says that while
repair is running the filesystem is vulnerable to machine outages.
Getting repair out of that hole would be a big job I suspect. It would
need to implement a journal and do all its work that way. Hmm, I cannot
remember if it actually does that for the most part to be honest.
Steve
|