| To: | Mitsuo Hayasaka <mitsuo.hayasaka.hu@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [RFC PATCH] xfs: pass KM_SLEEP flag to kmem_realloc() in xlog_recover_add_to_cnt_trans() |
| From: | Ben Myers <bpm@xxxxxxx> |
| Date: | Tue, 31 Jan 2012 11:50:53 -0600 |
| Cc: | Alex Elder <aelder@xxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Alex Elder <elder@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, xfs-masters@xxxxxxxxxxx, yrl.pp-manager.tt@xxxxxxxxxxx |
| In-reply-to: | <20120127063726.16227.681.stgit@xxxxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20120127063726.16227.681.stgit@xxxxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Fri, Jan 27, 2012 at 03:37:26PM +0900, Mitsuo Hayasaka wrote: > The kmem_realloc() in xfs is given KM_* memory allocation flags. And it > allocates memory using kmalloc() after they are converted to gfp_mask > flags. In xlog_recover_add_to_cont_trans(), 0u is passed to kmem_realloc(), > instead of them. I guess it is preferred to use them, and here memory must > be allocated but don't have to be done with GFP_ATOMIC. So, this patch > changes it to KM_SLEEP. > > Signed-off-by: Mitsuo Hayasaka <mitsuo.hayasaka.hu@xxxxxxxxxxx> > Cc: Ben Myers <bpm@xxxxxxx> > Cc: Alex Elder <elder@xxxxxxxxxx> > Cc: Christoph Hellwig <hch@xxxxxx> Looks good. Consistent with other kmem_*alloc in log recovery. Reviewed-by: Ben Myers <bpm@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Bug 916] New: xfs_log_force blocked, bugzilla-daemon |
|---|---|
| Next by Date: | Re: [PATCH] xfs: show uuid when mount fails due to duplicate uuid, Ben Myers |
| Previous by Thread: | Re: [RFC PATCH] xfs: pass KM_SLEEP flag to kmem_realloc() in xlog_recover_add_to_cnt_trans(), Christoph Hellwig |
| Next by Thread: | [patch] xfs: remove an unneeded NULL check, Dan Carpenter |
| Indexes: | [Date] [Thread] [Top] [All Lists] |