Re: [PATCH] XFS: Compare, don't assign in ASSERT() in xfs_trans

xfs-masters

Re: [PATCH] XFS: Compare, don't assign in ASSERT() in xfs_trans_unreserv

To:	Jesper Juhl <jj@xxxxxxxxxxxxx>
Subject:	Re: [PATCH] XFS: Compare, don't assign in ASSERT() in xfs_trans_unreserve_and_mod_sb()
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Tue, 28 Dec 2010 01:13:57 +1100
Cc:	xfs@xxxxxxxxxxx, xfs-masters@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Alex Elder <aelder@xxxxxxx>
In-reply-to:	<alpine.LNX.2.00.1012252110490.10759@xxxxxxxxxxxxxxxxxxxxxxxxx>
References:	<alpine.LNX.2.00.1012252110490.10759@xxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.20 (2009-06-14)

On Sat, Dec 25, 2010 at 09:14:53PM +0100, Jesper Juhl wrote:
> Hi,
> 
> In fs/xfs/xfs_trans.c::xfs_trans_unreserve_and_mod_sb() at the out: label 
> we have this:
>       ASSERT(error = 0);
> I believe a comparison was intended, not an assignment. If I'm right, the 
> patch below fixes that up.

Already fixed in this patch pending for 2.6.38:

http://git.kernel.org/?p=linux/kernel/git/dgc/xfsdev.git;a=commitdiff;h=831ef3cf682a1f9d8fc7c16dace55137751c0410

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] XFS: Compare, don't assign in ASSERT() in xfs_trans_unreserve_and_mod_sb(), Jesper Juhl Re: [PATCH] XFS: Compare, don't assign in ASSERT() in xfs_trans_unreserve_and_mod_sb(), Dave Chinner <=

Previous by Date:	HOTEL/MOTEL PHONES!!!!!!!, GLOBAL TELECOM LTD
Next by Date:	[Bug 904] XFS CPU soft lockup: xfs_write > try_to_free_pages > find_get_pages, bugzilla-daemon
Previous by Thread:	[PATCH] XFS: Compare, don't assign in ASSERT() in xfs_trans_unreserve_and_mod_sb(), Jesper Juhl
Next by Thread:	HOTEL/MOTEL PHONES!!!!!!!, GLOBAL TELECOM LTD
Indexes:	[Date] [Thread] [Top] [All Lists]