xfs-masters
[Top] [All Lists]

[Bug 873] xfstests #182 fails with recent quota change

To: xfs-masters@xxxxxxxxxxx
Subject: [Bug 873] xfstests #182 fails with recent quota change
From: bugzilla-daemon@xxxxxxxxxxx
Date: Tue, 16 Mar 2010 04:59:32 -0500
Auto-submitted: auto-generated
In-reply-to: <bug-873-113@xxxxxxxxxxxxxxxx/bugzilla/>
References: <bug-873-113@xxxxxxxxxxxxxxxx/bugzilla/>
http://oss.sgi.com/bugzilla/show_bug.cgi?id=873


Christoph Hellwig <hch@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hch@xxxxxxx




--- Comment #1 from Christoph Hellwig <hch@xxxxxxx>  2010-03-16 04:59:30 CST ---
Yes, I see this too.  I have tracked it down to removing the ->sync_fs call the
quota code uses to do when ->quota_sync was defined.  This got us a synchronous
sync before writing out the inodes if and only if quota support was compiled
in.  Without quota support this would already fail before.  I did a bit of
bisecting, and the only part of ->sync_fs we need is a:


 - xfs_flush_buftarg(mp->m_ddev_targp, 1);

adding a quota_sync method with just that call makes 182 work again.   In fact
moving that same call to the beginning of xfs_fs_sync_fs also fixes it, but I
haven't managed to figure out why we need to write out all delwri buffers
before the sync action.

-- 
Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

<Prev in Thread] Current Thread [Next in Thread>