xfs-masters
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH 11/11] fs/xfs: Correct NULL test

from [Christoph Hellwig] [Permanent Link][Original]
To: Julia Lawall <julia@xxxxxxx>
Subject: Re: [PATCH 11/11] fs/xfs: Correct NULL test
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 8 Feb 2010 14:37:26 -0500
Cc: Alex Elder <aelder@xxxxxxx>, xfs-masters@xxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <Pine.LNX.4.64.1002060944580.8092@xxxxxxxxxxx>
References: <Pine.LNX.4.64.1002060944580.8092@xxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05) 
On Sat, Feb 06, 2010 at 09:45:15AM +0100, Julia Lawall wrote:
> diff --git a/fs/xfs/quota/xfs_qm.c b/fs/xfs/quota/xfs_qm.c
> index 11cfd82..4318cd5 100644
> --- a/fs/xfs/quota/xfs_qm.c
> +++ b/fs/xfs/quota/xfs_qm.c
> @@ -123,7 +123,7 @@ xfs_Gqm_init(void)
>               goto out;
>  
>       gdqhash = kmem_zalloc_large(hsize);
> -     if (!udqhash)
> +     if (!gdqhash)
>               goto out_free_udqhash;

Thanks, this looks correct,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  [Bug 862] XFS bug crashes kernel when try_to_free_buffers, bugzilla-daemon
Next by Date:  [Bug 14387] deadlock with fallocate, bugzilla-daemon
Previous by Thread:  [PATCH 11/11] fs/xfs: Correct NULL test, Julia Lawall
Next by Thread:  [Bug 14387] deadlock with fallocate, bugzilla-daemon
Indexes:  [Date] [Thread] [Top] [All Lists]