xfs-masters
[Top] [All Lists]

Re: [xfs-masters] INFO: possible circular locking dependency detected

To: John Kacur <jkacur@xxxxxxxxxx>
Subject: Re: [xfs-masters] INFO: possible circular locking dependency detected
From: Christoph Hellwig <hch@xxxxxx>
Date: Sun, 11 Oct 2009 14:46:16 +0200
Cc: linux-kernel@xxxxxxxxxxxxxxx, xfs-masters@xxxxxxxxxxx, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
In-reply-to: <alpine.LFD.2.00.0910110108160.4921@xxxxxxxxxxxxxxxxxxxxx>
References: <alpine.LFD.2.00.0910110108160.4921@xxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.3.28i
This has been around for a long time, the VM calls into fput and thus
->release with the mmap_sem held, which makes it really hard for a
filesystem to avoid a lock inversion if it uses a lock both in ->release
and the I/O path.

I have a workaround for this to only acquire the XFS iolock with a
trylock in the release path and leave cleaning up stale preallocations
until the final iput.  It's not pretty, but given that we're unlikely
to see the VM fixed I might aswell finally send it for inclusion.

<Prev in Thread] Current Thread [Next in Thread>