xfs-masters
[Top] [All Lists]

Re: RFC: Fix f_flags races without the BKL

To: Jonathan Corbet <corbet@xxxxxxx>
Subject: Re: RFC: Fix f_flags races without the BKL
From: Andi Kleen <andi@xxxxxxxxxxxxxx>
Date: Tue, 30 Dec 2008 15:55:55 +0100
Cc: Andi Kleen <andi@xxxxxxxxxxxxxx>, Oleg Nesterov <oleg@xxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, bfields@xxxxxxxxxxxx, xfs-masters@xxxxxxxxxxx
In-reply-to: <20081230055956.1747bd86@tpl>
References: <20081229041352.6bbdf57c@tpl> <20081229124151.GA29634@redhat.com> <20081229152732.GH496@one.firstfloor.org> <20081230055956.1747bd86@tpl>
User-agent: Mutt/1.4.2.1i
On Tue, Dec 30, 2008 at 05:59:56AM -0700, Jonathan Corbet wrote:
> On Mon, 29 Dec 2008 16:27:32 +0100
> Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
> 
> > I would prefer O_LOCK_FLAGS bit too. The global lock is not very nice
> > and I don't doubt someone will come up with a workload which
> > pounds on it.
> 
> Seems hard to imagine that it would be worse than the longstanding BKL
> situation.  

As long as noone else uses it too BKL is faster than a mutex.

-Andi

-- 
ak@xxxxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>