xfs-masters
[Top] [All Lists]

Re: linux-next: xfs tree build failure

To: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>, xfs-masters@xxxxxxxxxxx, linux-next@xxxxxxxxxxxxxxx, Lachlan McIlroy <lachlan@xxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, hch@xxxxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx
Subject: Re: linux-next: xfs tree build failure
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 6 Nov 2008 10:27:53 -0500
In-reply-to: <20081105204754.GO4985@disturbed>
References: <20081030132324.0d619fdd.sfr@canb.auug.org.au> <20081030090832.GQ17077@disturbed> <20081105132000.4e560cad.sfr@canb.auug.org.au> <20081105204754.GO4985@disturbed>
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, Nov 06, 2008 at 07:47:54AM +1100, Dave Chinner wrote:
> > > I think it's probably the only solution - we need to wait until
> > > the I_LOCK bit is cleared from the inode and AFAICT wait_on_inode()
> > > is the only way to do it.
> > 
> > Any resolution?
> 
> I was waiting on a comment from Christoph. I'll cc him directly this
> time ;)

What comment do you expect from me?  The fix looks correct, but at some
point you should probably run all these exports past Al to get another
review.  Especially as he's doing major work in this area currently.

<Prev in Thread] Current Thread [Next in Thread>