xfs-masters
[Top] [All Lists]

[xfs-masters] Re: linux-next: xfs build failure

To: Christoph Hellwig <hch@xxxxxx>
Subject: [xfs-masters] Re: linux-next: xfs build failure
From: David Chinner <dgc@xxxxxxx>
Date: Tue, 22 Apr 2008 15:14:06 +1000
Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>, David Chinner <dgc@xxxxxxx>, xfs-masters@xxxxxxxxxxx, linux-next@xxxxxxxxxxxxxxx
In-reply-to: <20080422045700.GA24938@lst.de>
References: <20080422133547.c4c0a8ad.sfr@canb.auug.org.au> <20080422045700.GA24938@lst.de>
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Tue, Apr 22, 2008 at 06:57:00AM +0200, Christoph Hellwig wrote:
> On Tue, Apr 22, 2008 at 01:35:47PM +1000, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Today's linux-next build (x86_64 allmodconfig) fails like this:
> > 
> > fs/xfs/linux-2.6/xfs_buf.c: In function 'xfs_buf_lock_value':
> > fs/xfs/linux-2.6/xfs_buf.c:889: error: request for member 'counter' in 
> > something not a structure or union
> > 
> > The commit 64ac24e738823161693bf791f87adc802cf529ff ("Generic semaphore
> > implementation") in Linus' tree changed the count in a semaphore from
> > atomic_t to int.  I applied the following patch which is clearly not
> > correct but builds.
> 
> Actually it is correct.  xfs_buf_lock_value is a debug-only helper to
> display the semaphore value in traces or a debugger.

So the config is building an XFS_DEBUG config. This will be the first time
mainline is building those as that config option was merged into the -master
branch of the xfs git tree yesterday.

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group


<Prev in Thread] Current Thread [Next in Thread>