xfs-masters
[Top] [All Lists]

[xfs-masters] Re: linux-next: xfs build failure

To: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
Subject: [xfs-masters] Re: linux-next: xfs build failure
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 22 Apr 2008 06:57:00 +0200
Cc: David Chinner <dgc@xxxxxxx>, xfs-masters@xxxxxxxxxxx, linux-next@xxxxxxxxxxxxxxx
In-reply-to: <20080422133547.c4c0a8ad.sfr@canb.auug.org.au>
References: <20080422133547.c4c0a8ad.sfr@canb.auug.org.au>
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Tue, Apr 22, 2008 at 01:35:47PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Today's linux-next build (x86_64 allmodconfig) fails like this:
> 
> fs/xfs/linux-2.6/xfs_buf.c: In function 'xfs_buf_lock_value':
> fs/xfs/linux-2.6/xfs_buf.c:889: error: request for member 'counter' in 
> something not a structure or union
> 
> The commit 64ac24e738823161693bf791f87adc802cf529ff ("Generic semaphore
> implementation") in Linus' tree changed the count in a semaphore from
> atomic_t to int.  I applied the following patch which is clearly not
> correct but builds.

Actually it is correct.  xfs_buf_lock_value is a debug-only helper to
display the semaphore value in traces or a debugger.


<Prev in Thread] Current Thread [Next in Thread>