| To: | Alexey Dobriyan <adobriyan@xxxxxxxxx> |
|---|---|
| Subject: | [xfs-masters] Re: [PATCH] XFS: convert proc files to seq_file interface |
| From: | Christoph Hellwig <hch@xxxxxx> |
| Date: | Sun, 13 Apr 2008 01:04:11 +0200 |
| Cc: | xfs-masters@xxxxxxxxxxx, hch@xxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx |
| In-reply-to: | <20080412210131.GB9151@martell.zuzino.mipt.ru> |
| References: | <20080412210131.GB9151@martell.zuzino.mipt.ru> |
| Reply-to: | xfs-masters@xxxxxxxxxxx |
| Sender: | xfs-masters-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.3.28i |
Looks good except for a little style nitpick:
> + for (i=j = 0; i < ARRAY_SIZE(xstats); i++) {
I'd rather initialize j outside of the loop, and fix the spacing to the
standard one
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [xfs-masters] [Bug 780] please add the -p option to fsck.xfs, bugzilla-daemon |
|---|---|
| Next by Date: | [xfs-masters] [Bug 10421] Filesystem failing without any warning or etc, bugme-daemon |
| Previous by Thread: | [xfs-masters] [PATCH] XFS: convert proc files to seq_file interface, Alexey Dobriyan |
| Next by Thread: | [xfs-masters] [Bug 7668] XFS mount of LVM2 snapshot hangs occasionally, bugme-daemon |
| Indexes: | [Date] [Thread] [Top] [All Lists] |