xfs-masters
[Top] [All Lists]

[xfs-masters] Re: [Patch 7/8] FS: Remove 'TOPDIR' from Makefiles

To: WANG Cong <xiyou.wangcong@xxxxxxxxx>
Subject: [xfs-masters] Re: [Patch 7/8] FS: Remove 'TOPDIR' from Makefiles
From: Sam Ravnborg <sam@xxxxxxxxxxxx>
Date: Tue, 1 Jan 2008 11:30:26 +0100
Cc: Tim Shimmin <xfs-masters@xxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, linux-kbuild@xxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxx>, viro@xxxxxxxxxxxxxxxxxx
In-reply-to: <20080101074105.GH2496@hacking>
References: <20080101071311.GA2496@hacking> <20080101074105.GH2496@hacking>
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Tue, Jan 01, 2008 at 03:41:05PM +0800, WANG Cong wrote:
> 
> TOPDIR is obsolete, use objtree instead.
> This patch removes TOPDIR from all fs/ Makefiles.
> 
> Cc: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>
> Cc: Tim Shimmin <xfs-masters@xxxxxxxxxxx>
> Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Signed-off-by: WANG Cong <xiyou.wangcong@xxxxxxxxx>
> 
> ---
> 
> diff --git a/fs/smbfs/Makefile b/fs/smbfs/Makefile
> index 6673ee8..9b5e92b 100644
> --- a/fs/smbfs/Makefile
> +++ b/fs/smbfs/Makefile
> @@ -34,5 +34,5 @@ proto:
>       @echo >> proto2.h "struct sock;"
>       @echo >> proto2.h "struct statfs;"
>       @echo >> proto2.h ""
> -     cproto -E "gcc -E" -e -v -I $(TOPDIR)/include -DMAKING_PROTO 
> -D__KERNEL__ $(SRC) >> proto2.h
> +     cproto -E "gcc -E" -e -v -I $(objtree)/include -DMAKING_PROTO 
> -D__KERNEL__ $(SRC) >> proto2.h
>       mv proto2.h proto.h
> diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile
> index 49e3e7e..d1d3d49 100644
> --- a/fs/xfs/Makefile
> +++ b/fs/xfs/Makefile
> @@ -1 +1 @@
> -include $(TOPDIR)/fs/xfs/Makefile-linux-$(VERSION).$(PATCHLEVEL)
> +include $(objtree)/fs/xfs/Makefile-linux-$(VERSION).$(PATCHLEVEL)

The whole "Maintainer rules" part of this file should be deleted.
I cannot see how it can be used anyway.

        Sam


<Prev in Thread] Current Thread [Next in Thread>