[xfs-masters] Re: 2.6.22-rc1-mm1

[Christoph Hellwig <hch@xxxxxx>]

On Tue, May 22, 2007 at 08:44:30PM +1000, David Chinner wrote:
> Perhaps a new field in the xfs_buf structure - that way call paths
> don't need to grow extra parameters and potentially increase
> stack usage. The read path tends to be at the top of the stack
> when it gets blown in the writeback path....

I have some patches to unwind the buffer I/O path, it's a little
to overcomplicated due to historical reasons.

> >    the offset in xlog_sync aswell.
> 
> I don't want to have to introduce a mempool just for one xfs_buf per
> filesystem, so this would need to be able to take a xfs_buf (log->l_xbuf)
> that it clones to....

Yes.  Note that we currently do a non-mempooled allocated for the page
array, which this would cure aswell.