xfs-masters
[Top] [All Lists]

[xfs-masters] Re: [PATCH} XFS: Remove placeholders for unimplemented fun

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: [xfs-masters] Re: [PATCH} XFS: Remove placeholders for unimplemented functionality.
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 29 Jan 2007 07:01:03 +0000
Cc: xfs-masters@xxxxxxxxxxx, Linux kernel mailing list <linux-kernel@xxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, dgc@xxxxxxx
In-reply-to: <45BD7F0A.1000004@sandeen.net>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxxx>, xfs-masters@xxxxxxxxxxx, Linux kernel mailing list <linux-kernel@xxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, dgc@xxxxxxx
References: <Pine.LNX.4.64.0701281557410.11046@CPE00045a9c397f-CM001225dbafb6> <45BD7F0A.1000004@sandeen.net>
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.2i
On Sun, Jan 28, 2007 at 10:58:50PM -0600, Eric Sandeen wrote:
> >-#else
> > #define xfs_cap_vset(v,p,sz)        (-EOPNOTSUPP)
> > #define xfs_cap_vget(v,p,sz)        (-EOPNOTSUPP)
> > #define xfs_cap_vremove(v)  (-EOPNOTSUPP)
> > #define _CAP_EXISTS         (NULL)
> >-#endif
> >
> > #endif      /* __KERNEL__ */
> 
> By the time you do this, probably may as well remove the whole file; the 
> leftover 4 definitions never seem to be used.
> 
> The same may go for xfs_mac.h.

Agreed.  As Dave said if we get this functionality on Linux it will most
likely be handled at a different level, so keeping the old IRIX-style hooks
is rather pointless.


<Prev in Thread] Current Thread [Next in Thread>