xfs-masters
[Top] [All Lists]

[xfs-masters] Re: [PATCH] xfs: kill kmem_zone init

To: xfs-masters@xxxxxxxxxxx
Subject: [xfs-masters] Re: [PATCH] xfs: kill kmem_zone init
From: David Chinner <dgc@xxxxxxx>
Date: Thu, 23 Mar 2006 12:36:31 +1100
Cc: Nathan Scott <nathans@xxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <Pine.LNX.4.58.0603220932230.27326@sbz-30.cs.Helsinki.FI>
References: <Pine.LNX.4.58.0603201501540.18684@sbz-30.cs.Helsinki.FI> <20060321082037.A653275@wobbly.melbourne.sgi.com> <Pine.LNX.4.58.0603210859450.14023@sbz-30.cs.Helsinki.FI> <20060322085520.A664708@wobbly.melbourne.sgi.com> <Pine.LNX.4.58.0603220932230.27326@sbz-30.cs.Helsinki.FI>
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Wed, Mar 22, 2006 at 09:37:33AM +0200, Pekka J Enberg wrote:
> Would 
> you accept patches to convert code under PF_FSTRANS to use KM_NOFS so we 
> can kill the check in kmem_flags_convert()?

No.

XFS is full of code that can be called under both PF_FSTRANS and
!PF_FSTRANS contexts and hence recursion during allocation is
context dependent. Rather than pollute >20 call sites throughout XFS
with this check it got put in common code. Makes sense, yes?

Cheers,

Dave.
-- 
Dave Chinner
R&D Software Enginner
SGI Australian Software Group


<Prev in Thread] Current Thread [Next in Thread>