xfs-masters
[Top] [All Lists]

[xfs-masters] [Bug 413] read-only mount attempts write on umount

To: xfs-master@xxxxxxxxxxx
Subject: [xfs-masters] [Bug 413] read-only mount attempts write on umount
From: bugzilla-daemon@xxxxxxxxxxx
Date: Thu, 8 Sep 2005 02:42:42 -0700
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
http://oss.sgi.com/bugzilla/show_bug.cgi?id=413





------- Additional Comments From mzeng@xxxxxxxxxx  2005-09-08 02:42 CST -------
I am using kernel-2.4.21-27.0.2.EL.sgi9.src.rpm that is downloaded from sgi 
site for our system and also accounted this bug. From the source, I find the 
bug dues to the XFS file system tries to write to the readonly mounted file 
system, I made the below patch and find it seems the patch fixes this bug, can 
anyone give the confirmation if this patch really works?


diff -U 8 -rN --exclude='*.o' --exclude='*.orig' xfs-kern.old/linux/xfs_super.c 
xfs-kern.new/linux/xfs_super.c
--- xfs-kern.old/linux/xfs_super.c      2005-09-08 17:02:33.000000000 +0800
+++ xfs-kern.new/linux/xfs_super.c      2005-09-08 16:30:46.000000000 +0800
@@ -580,16 +580,20 @@
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,21)
 STATIC int
 linvfs_sync_super(
        struct super_block      *sb)
 {
        vfs_t           *vfsp = LINVFS_GET_VFS(sb);
        int             error;

+       if (sb->s_flags & MS_RDONLY) {
+               sb->s_dirt = 0; /* paranoia */
+               return;
+       }
        VFS_SYNC(vfsp, SYNC_FSDATA|SYNC_WAIT, NULL, error);
        return -error;
 }
 #endif

 STATIC int
 linvfs_statfs(
        struct super_block      *sb,

-- 
Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


<Prev in Thread] Current Thread [Next in Thread>