xfs-masters
[Top] [All Lists]

Re: [PATCH 1/9] lib/vsprintf.c: Add %pU to print UUID/GUIDs

To: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Subject: Re: [PATCH 1/9] lib/vsprintf.c: Add %pU to print UUID/GUIDs
From: Joe Perches <joe@xxxxxxxxxxx>
Date: Thu, 01 Oct 2009 00:26:40 -0700
Cc: linux-kernel@xxxxxxxxxxxxxxx, Adrian Hunter <adrian.hunter@xxxxxxxxx>, Alex Elder <aelder@xxxxxxx>, Artem Bityutskiy <dedekind@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Harvey Harrison <harvey.harrison@xxxxxxxxx>, Huang Ying <ying.huang@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Jeff Garzik <jgarzik@xxxxxxxxxx>, Laurent Pinchart <laurent.pinchart@xxxxxxxxx>, Matt Mackall <mpm@xxxxxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>, Neil Brown <neilb@xxxxxxx>, Steven Whitehouse <swhiteho@xxxxxxxxxx>, xfs-masters@xxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>
In-reply-to: <10f740e80910010010o4522a008h265e09d7988d7192@xxxxxxxxxxxxxx>
References: <cover.1254193019.git.joe@xxxxxxxxxxx> <f28939e0018c7e2a9e898722e0fb8514a843b14c.1254193019.git.joe@xxxxxxxxxxx> <10f740e80910010010o4522a008h265e09d7988d7192@xxxxxxxxxxxxxx>
On Thu, 2009-10-01 at 09:10 +0200, Geert Uytterhoeven wrote:
> > Standardize the printed style of UUID/GUIDs by using
> > another extension to %p.
> >
> > %pU:    01020304-0506-0708-090a-0b0c0d0e0f10
> > %pUr:   04030201-0605-0807-090a-0b0c0d0e0f10
> > %pU[r]X:Use upper case hex
> 
> To me, it looks a bit strange to have the options after the `U', combined with
> the variable-length nature.

I think the whole %p<foo> mechanism is strange and takes
a bit of getting used to.

You're free to suggest alternatives.

Keep in mind expansion for future different types and that
<foo> must be alphanumeric chars only.

cheers, Joe

<Prev in Thread] Current Thread [Next in Thread>