xfs-masters
[Top] [All Lists]

[xfs-masters] Re: [E1000-devel] [PATCH] drivers/net: convert & to &&

To: "Kok, Auke" <auke-jan.h.kok@xxxxxxxxx>
Subject: [xfs-masters] Re: [E1000-devel] [PATCH] drivers/net: convert & to &&
From: Joe Perches <joe@xxxxxxxxxxx>
Date: Fri, 07 Mar 2008 10:20:33 -0800
Cc: Julia Lawall <julia@xxxxxxx>, e1000-devel@xxxxxxxxxxxxxxxxxxxxx, xfs-masters <xfs-masters@xxxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <47D032FA.9000909@intel.com>
References: <Pine.LNX.4.58.0803061841000.1669@pc-041.diku.dk> <1204826347.5541.20.camel@localhost> <47D032FA.9000909@intel.com>
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
On Thu, 2008-03-06 at 10:07 -0800, Kok, Auke wrote:
> (which, BTW also could use the uint32_t -> u32 (etc) changes... while you're 
> at it)

I think this does what you want:

for size in "8" "16" "32" "64" ; do \
sed -r -i -e 's/\bu_{0,1}int'$size'_t\b/u'$size'/g' \
$(grep -rPlw --include=*.[ch] 'u_{0,1}int'$size'_t' drivers/net/e1000 
drivers/net/ixgb); done

But why?  boolean_t is used by 3 subsystems with local typedefs.
These others are much more frequently used by kernel source.

$ grep -rPlw --include=*.[ch] "u{0,1}_{0,1}int(8|16|32|64)_t" * | wc -l
876

include/linux/types.h has typedefs for these but not boolean_t

include/linux/types.h:typedef           __u8            u_int8_t;
include/linux/types.h:typedef           __s8            int8_t;
include/linux/types.h:typedef           __u16           u_int16_t;
include/linux/types.h:typedef           __s16           int16_t;
include/linux/types.h:typedef           __u32           u_int32_t;
include/linux/types.h:typedef           __s32           int32_t;
include/linux/types.h:typedef           __u8            uint8_t;
include/linux/types.h:typedef           __u16           uint16_t;
include/linux/types.h:typedef           __u32           uint32_t;
include/linux/types.h:typedef           __u64           uint64_t;
include/linux/types.h:typedef           __u64           u_int64_t;
include/linux/types.h:typedef           __s64           int64_t;

cheers, Joe


<Prev in Thread] Current Thread [Next in Thread>