| To: | xfs-masters@xxxxxxxxxxx |
|---|---|
| Subject: | [xfs-masters] [PATCH]is_power_of_2-xfs/xfs_inode.c |
| From: | vignesh babu <vignesh.babu@xxxxxxxxx> |
| Date: | Thu, 14 Jun 2007 13:39:42 +0530 |
| Cc: | xfs@xxxxxxxxxxx, Kernel Janitors List <kernel-janitors@xxxxxxxxxxxxxx> |
| Organization: | WIPRO Technologies |
| Reply-to: | xfs-masters@xxxxxxxxxxx |
| Sender: | xfs-masters-bounce@xxxxxxxxxxx |
Replacing (n & (n-1)) in the context of power of 2 checks
with is_power_of_2
Signed-off-by: vignesh babu <vignesh.babu@xxxxxxxxx>
---
diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
index 3ca5d43..8fdd30d 100644
--- a/fs/xfs/xfs_inode.c
+++ b/fs/xfs/xfs_inode.c
@@ -49,6 +49,7 @@
#include "xfs_quota.h"
#include "xfs_acl.h"
+#include <linux/log2.h>
kmem_zone_t *xfs_ifork_zone;
kmem_zone_t *xfs_inode_zone;
@@ -4184,7 +4185,7 @@ xfs_iext_realloc_direct(
ifp->if_bytes = new_size;
return;
}
- if ((new_size & (new_size - 1)) != 0) {
+ if (!is_power_of_2(new_size)){
rnew_size = xfs_iroundup(new_size);
}
if (rnew_size != ifp->if_real_bytes) {
@@ -4207,7 +4208,7 @@ xfs_iext_realloc_direct(
*/
else {
new_size += ifp->if_bytes;
- if ((new_size & (new_size - 1)) != 0) {
+ if (!is_power_of_2(new_size)) {
rnew_size = xfs_iroundup(new_size);
}
xfs_iext_inline_to_direct(ifp, rnew_size);
--
Vignesh Babu BM
_____________________________________________________________
"Why is it that every time I'm with you, makes me believe in magic?"
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [xfs-masters] [Bug 642] respect LDFLAGS settings from configure, bugzilla-daemon |
|---|---|
| Next by Date: | [xfs-masters] [Bug 760] attr-2.4.38: LTLDFLAGS set in environment are ignored because of typo in libattr/Makefile, bugzilla-daemon |
| Previous by Thread: | [xfs-masters] [Bug 642] respect LDFLAGS settings from configure, bugzilla-daemon |
| Next by Thread: | [xfs-masters] Re: [PATCH]is_power_of_2-xfs/xfs_inode.c, David Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |