xfs-masters
[Top] [All Lists]

[xfs-masters] Re: [PATCH 36/59] sysctl: C99 convert ctl_tables entries i

To: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
Subject: [xfs-masters] Re: [PATCH 36/59] sysctl: C99 convert ctl_tables entries in arch/ppc/kernel/ppc_htab.c
From: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 17 Jan 2007 14:16:54 +1100
Cc: "<Andrew Morton" <akpm@xxxxxxxx>, linux-mips@xxxxxxxxxxxxxx, linux-parport@xxxxxxxxxxxxxxxxxxx, heiko.carstens@xxxxxxxxxx, ak@xxxxxxx, linuxppc-dev@xxxxxxxxxx, paulus@xxxxxxxxx, aharkes@xxxxxxxxxx, schwidefsky@xxxxxxxxxx, tim@xxxxxxxxxxxx, rtc-linux@xxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, kurt.hackel@xxxxxxxxxx, coda@xxxxxxxxxx, vojtech@xxxxxxx, linuxsh-shmedia-dev@xxxxxxxxxxxxxxxxxxxxx, James.Bottomley@xxxxxxxxxxxx, clemens@xxxxxxxxxx, xfs@xxxxxxxxxxx, xfs-masters@xxxxxxxxxxx, andrea@xxxxxxx, openipmi-developer@xxxxxxxxxxxxxxxxxxxxx, linux-390@xxxxxxxxxxxxx, codalist@xxxxxxxxxxxxxxxxxxxxxxxx, a.zummo@xxxxxxxxxxxx, tony.luck@xxxxxxxxx, linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, aia21@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, ralf@xxxxxxxxxxxxxx, lethal@xxxxxxxxxxxx, containers@xxxxxxxxxxxxxx, linux390@xxxxxxxxxx, philb@xxxxxxx
In-reply-to: <11689656602523-git-send-email-ebiederm@xmission.com>
References: <m1ac0jc4no.fsf@ebiederm.dsl.xmission.com> <11689656602523-git-send-email-ebiederm@xmission.com>
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
On Tue, 2007-01-16 at 09:39 -0700, Eric W. Biederman wrote:
> From: Eric W. Biederman <ebiederm@xxxxxxxxxxxx> - unquoted
> 
> And make the mode of the kernel directory 0555 no one is allowed
> to write to sysctl directories.
> 
> Signed-off-by: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>

Acked-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>

> ---
>  arch/ppc/kernel/ppc_htab.c |   11 ++++++++---
>  1 files changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/ppc/kernel/ppc_htab.c b/arch/ppc/kernel/ppc_htab.c
> index bd129d3..77b20ff 100644
> --- a/arch/ppc/kernel/ppc_htab.c
> +++ b/arch/ppc/kernel/ppc_htab.c
> @@ -442,11 +442,16 @@ static ctl_table htab_ctl_table[]={
>               .mode           = 0644,
>               .proc_handler   = &proc_dol2crvec,
>       },
> -     { 0, },
> +     {}
>  };
>  static ctl_table htab_sysctl_root[] = {
> -     { 1, "kernel", NULL, 0, 0755, htab_ctl_table, },
> -     { 0,},
> +     {
> +             .ctl_name       = CTL_KERN,
> +             .procname       = "kernel",
> +             .mode           = 0555,
> +             .child          = htab_ctl_table,
> +     },
> +     {}
>  };
>  
>  static int __init


<Prev in Thread] Current Thread [Next in Thread>