xfs-masters
[Top] [All Lists]

[xfs-masters] [PATCH 43/59] sysctl: Remove sys_sysctl support from drive

To: "<Andrew Morton" <akpm@xxxxxxxx>
Subject: [xfs-masters] [PATCH 43/59] sysctl: Remove sys_sysctl support from drivers/char/rtc.c
From: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
Date: Tue, 16 Jan 2007 09:39:48 -0700
Cc: <linux-kernel@xxxxxxxxxxxxxxx>, <containers@xxxxxxxxxxxxxx>, <netdev@xxxxxxxxxxxxxxx>, xfs-masters@xxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, James.Bottomley@xxxxxxxxxxxx, minyard@xxxxxxx, openipmi-developer@xxxxxxxxxxxxxxxxxxxxx, <tony.luck@xxxxxxxxx>, linux-mips@xxxxxxxxxxxxxx, ralf@xxxxxxxxxxxxxx, schwidefsky@xxxxxxxxxx, heiko.carstens@xxxxxxxxxx, linux390@xxxxxxxxxx, linux-390@xxxxxxxxxxxxx, paulus@xxxxxxxxx, linuxppc-dev@xxxxxxxxxx, lethal@xxxxxxxxxxxx, linuxsh-shmedia-dev@xxxxxxxxxxxxxxxxxxxxx, <ak@xxxxxxx>, vojtech@xxxxxxx, clemens@xxxxxxxxxx, a.zummo@xxxxxxxxxxxx, rtc-linux@xxxxxxxxxxxxxxxx, linux-parport@xxxxxxxxxxxxxxxxxxx, andrea@xxxxxxx, tim@xxxxxxxxxxxx, philb@xxxxxxx, aharkes@xxxxxxxxxx, coda@xxxxxxxxxx, codalist@xxxxxxxxxxxxxxxxxxxxxxxx, aia21@xxxxxxxxxx, linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx, mark.fasheh@xxxxxxxxxx, kurt.hackel@xxxxxxxxxx, "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
In-reply-to: <m1ac0jc4no.fsf@ebiederm.dsl.xmission.com>
References: <m1ac0jc4no.fsf@ebiederm.dsl.xmission.com>
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
From: Eric W. Biederman <ebiederm@xxxxxxxxxxxx> - unquoted

The real time clock driver was using the binary number reserved
for cdroms in the sysctl binary number interface, which is a no-no.
So since the sysctl binary interface is wrong remove it.

Signed-off-by: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
---
 drivers/char/rtc.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/char/rtc.c b/drivers/char/rtc.c
index 664f36c..df11289 100644
--- a/drivers/char/rtc.c
+++ b/drivers/char/rtc.c
@@ -282,7 +282,7 @@ irqreturn_t rtc_interrupt(int irq, void *dev_id)
  */
 static ctl_table rtc_table[] = {
        {
-               .ctl_name       = 1,
+               .ctl_name       = CTL_UNNUMBERED,
                .procname       = "max-user-freq",
                .data           = &rtc_max_user_freq,
                .maxlen         = sizeof(int),
@@ -294,9 +294,8 @@ static ctl_table rtc_table[] = {
 
 static ctl_table rtc_root[] = {
        {
-               .ctl_name       = 1,
+               .ctl_name       = CTL_UNNUMBERED,
                .procname       = "rtc",
-               .maxlen         = 0,
                .mode           = 0555,
                .child          = rtc_table,
        },
@@ -307,7 +306,6 @@ static ctl_table dev_root[] = {
        {
                .ctl_name       = CTL_DEV,
                .procname       = "dev",
-               .maxlen         = 0,
                .mode           = 0555,
                .child          = rtc_root,
        },
-- 
1.4.4.1.g278f


<Prev in Thread] Current Thread [Next in Thread>