xfs-masters
[Top] [All Lists]

[xfs-masters] Re: [-mm PATCH 2/32] fs: fix-up schedule_timeout() usage

To: Nishanth Aravamudan <nacc@xxxxxxxxxx>
Subject: [xfs-masters] Re: [-mm PATCH 2/32] fs: fix-up schedule_timeout() usage
From: "Stephen C. Tweedie" <sct@xxxxxxxxxx>
Date: Mon, 15 Aug 2005 19:37:14 +0100
Cc: sfrench@xxxxxxxxx, okir@xxxxxxxxxxxxxxxxxxxx, Trond Myklebust <trond.myklebust@xxxxxxxxxx>, reiserfs-dev@xxxxxxxxxxx, urban@xxxxxxxxxxxxxxx, xfs-masters@xxxxxxxxxxx, Nathan Scott <nathans@xxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, samba-technical@xxxxxxxxxxxxxxx, linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>, reiserfs-list@xxxxxxxxxxx, samba@xxxxxxxxx, linux-xfs@xxxxxxxxxxx, Stephen Tweedie <sct@xxxxxxxxxx>
In-reply-to: <20050815180804.GE2854@us.ibm.com>
References: <20050815180514.GC2854@us.ibm.com> <20050815180804.GE2854@us.ibm.com>
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
Hi,

On Mon, 2005-08-15 at 19:08, Nishanth Aravamudan wrote:

> Description: Use schedule_timeout_{,un}interruptible() instead of
> set_current_state()/schedule_timeout() to reduce kernel size.

> +++ 2.6.13-rc5-mm1-dev/fs/jbd/transaction.c   2005-08-10 15:03:33.000000000 
> -0700
> @@ -1340,8 +1340,7 @@ int journal_stop(handle_t *handle)
> -                     set_current_state(TASK_UNINTERRUPTIBLE);
> -                     schedule_timeout(1);
> +                     schedule_timeout_uninterruptible(1);

This chunk at least is fine.

--Stephen


<Prev in Thread] Current Thread [Next in Thread>