Re: [PATCH] libxfs: Get Physical Sector Size instead of Logical Sector size

["Martin K. Petersen" <martin.petersen@xxxxxxxxxx>]

>>>>> "Eric" == Eric Sandeen <sandeen@xxxxxxxxxxx> writes:

Eric> It seems that we should be checking for any alignment offsets in
Eric> libxfs then, too; if there IS an offset, then perhaps 4k is the
Eric> wrong answer, (perhaps there is no right answer) but if there is
Eric> NO offset, 4k should be the right choice, yes?

In most cases the partitioning/DM tools should give you a 0 offset. But
it would a good idea to at least print a warning if lbs != pbs and
offset > 0.


Eric> And if the drive is broken then c'est la vie?

Yes :)


FWIW, the reason 4KB lbs drives are having a revival in the is that
there is not a lot of confidence in 512e for the enterprise. Many
vendors won't support them in servers due to correctness concerns and
lack of performance predictability.

-- 
Martin K. Petersen      Oracle Linux Engineering