Re: [PATCH 2/3] block: require write_same and discard requests align to

xfs

Re: [PATCH 2/3] block: require write_same and discard requests align to

To:	"Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Subject:	Re: [PATCH 2/3] block: require write_same and discard requests align to logical block size
From:	"Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date:	Wed, 29 Jun 2016 00:58:06 -0400
Cc:	axboe@xxxxxxxxx, hch@xxxxxxxxxxxxx, tytso@xxxxxxx, martin.petersen@xxxxxxxxxx, snitzer@xxxxxxxxxx, linux-api@xxxxxxxxxxxxxxx, bfoster@xxxxxxxxxx, xfs@xxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<146612626092.12764.773833541076937471.stgit@xxxxxxxxxxxxxxxx> (Darrick J. Wong's message of "Thu, 16 Jun 2016 18:17:41 -0700")
Organization:	Oracle Corporation
References:	<146612624734.12764.4316680863289411106.stgit@xxxxxxxxxxxxxxxx> <146612626092.12764.773833541076937471.stgit@xxxxxxxxxxxxxxxx>
User-agent:	Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

>>>>> "Darrick" == Darrick J Wong <darrick.wong@xxxxxxxxxx> writes:

Darrick> Make sure that the offset and length arguments that we're using
Darrick> to construct WRITE SAME and DISCARD requests are actually
Darrick> aligned to the logical block size.  Failure to do this causes
Darrick> other errors in other parts of the block layer or the SCSI
Darrick> layer because disks don't support partial logical block writes.

Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

-- 
Martin K. Petersen      Oracle Linux Engineering

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH v9 0/3] fallocate for block devices, Darrick J. Wong [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT., Darrick J. Wong Re: [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT., Bart Van Assche Re: [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT., Darrick J. Wong Re: [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT., Martin K. Petersen [PATCH 2/3] block: require write_same and discard requests align to logical block size, Darrick J. Wong Re: [PATCH 2/3] block: require write_same and discard requests align to logical block size, Bart Van Assche Re: [PATCH 2/3] block: require write_same and discard requests align to logical block size, Martin K. Petersen <= [PATCH 3/3] block: implement (some of) fallocate for block devices, Darrick J. Wong

Previous by Date:	Re: [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT., Martin K. Petersen
Next by Date:	[ANNOUNCE] xfsprogs: master branch updated to ee37542, Dave Chinner
Previous by Thread:	Re: [PATCH 2/3] block: require write_same and discard requests align to logical block size, Bart Van Assche
Next by Thread:	[PATCH 3/3] block: implement (some of) fallocate for block devices, Darrick J. Wong
Indexes:	[Date] [Thread] [Top] [All Lists]