xfs
[Top] [All Lists]

Re: [PATCH 02/35] block: add REQ_OP definitions and bi_op/op fields

To: mchristi@xxxxxxxxxx
Subject: Re: [PATCH 02/35] block: add REQ_OP definitions and bi_op/op fields
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Wed, 06 Jan 2016 18:17:01 -0500
Cc: linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, konrad.wilk@xxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx, philipp.reisner@xxxxxxxxxx, lars.ellenberg@xxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, osd-dev@xxxxxxxxxxxx, xfs@xxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1452027218-32303-3-git-send-email-mchristi@xxxxxxxxxx> (mchristi@xxxxxxxxxx's message of "Tue, 5 Jan 2016 14:53:05 -0600")
Organization: Oracle
References: <1452027218-32303-1-git-send-email-mchristi@xxxxxxxxxx> <1452027218-32303-3-git-send-email-mchristi@xxxxxxxxxx>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
>>>>> "Mike" == mchristi  <mchristi@xxxxxxxxxx> writes:

+enum req_op {
+       REQ_OP_READ,
+       REQ_OP_WRITE            = REQ_WRITE,
+       REQ_OP_DISCARD          = REQ_DISCARD,
+       REQ_OP_WRITE_SAME       = REQ_WRITE_SAME,
+};
+

I have been irked by the REQ_ prefix in bios since the flags were
consolidated a while back. When I attempted to fix the READ/WRITE mess I
used a BLK_ prefix as a result.

Anyway. Just bikeshedding...

-- 
Martin K. Petersen      Oracle Linux Engineering

<Prev in Thread] Current Thread [Next in Thread>