xfs
[Top] [All Lists]

Re: [PATCH v2 4/5] dax: use sb_issue_zerout instead of calling dax_clear

To: Vishal Verma <vishal.l.verma@xxxxxxxxx>
Subject: Re: [PATCH v2 4/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors
From: Jeff Moyer <jmoyer@xxxxxxxxxx>
Date: Fri, 15 Apr 2016 11:18:22 -0400
Cc: linux-nvdimm@xxxxxxxxxxx, Jens Axboe <axboe@xxxxxx>, Jan Kara <jack@xxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1459303190-20072-5-git-send-email-vishal.l.verma@xxxxxxxxx> (Vishal Verma's message of "Tue, 29 Mar 2016 19:59:49 -0600")
References: <1459303190-20072-1-git-send-email-vishal.l.verma@xxxxxxxxx> <1459303190-20072-5-git-send-email-vishal.l.verma@xxxxxxxxx>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
Vishal Verma <vishal.l.verma@xxxxxxxxx> writes:

> From: Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx>
>
> dax_clear_sectors() cannot handle poisoned blocks.  These must be
> zeroed using the BIO interface instead.  Convert ext2 and XFS to use
> only sb_issue_zerout().
>
> Signed-off-by: Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx>
> [vishal: Also remove the dax_clear_sectors function entirely]
> Signed-off-by: Vishal Verma <vishal.l.verma@xxxxxxxxx>

Reviewed-by: Jeff Moyer <jmoyer@xxxxxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH v2 4/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors, Jeff Moyer <=