| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 3/9] xfs: factor out everything but the filemap_write_and_wait from xfs_file_fsync |
| From: | Jeff Moyer <jmoyer@xxxxxxxxxx> |
| Date: | Wed, 21 Nov 2012 09:10:35 -0500 |
| Cc: | "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>, axboe@xxxxxxxxx, tytso@xxxxxxx, david@xxxxxxxxxxxxx, bpm@xxxxxxx, viro@xxxxxxxxxxxxxxxxxx, jack@xxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| In-reply-to: | <20121121100913.GF23339@xxxxxxxxxxxxx> (Christoph Hellwig's message of "Wed, 21 Nov 2012 05:09:13 -0500") |
| References: | <20121120074116.24645.36369.stgit@xxxxxxxxxxxxxxxxxxx> <20121120074138.24645.36708.stgit@xxxxxxxxxxxxxxxxxxx> <20121121100913.GF23339@xxxxxxxxxxxxx> |
| User-agent: | Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) |
Christoph Hellwig <hch@xxxxxxxxxxxxx> writes: > On Mon, Nov 19, 2012 at 11:41:38PM -0800, Darrick J. Wong wrote: >> Hi, >> >> Fsyncing is tricky business, so factor out the bits of the xfs_file_fsync >> function that can be used from the I/O post-processing path. > > Why would we need to skip the filemap_write_and_wait_range call here? > If we're doing direct I/O we should not have any pages in this regions > anyway. You're also not skipping it in the generic implementation as > far as I can see, so I see no point in doing it just in XFS. OK, I'll fix that. Thanks! Jeff |
| Previous by Date: | Re: [PATCH 0/3] xfstests: remove unused code and resolve warnings, Rich Johnston |
|---|---|
| Next by Date: | Re: [PATCH] xfs: Don't flush inodes when project quota exceeded, Brian Foster |
| Previous by Thread: | Re: [PATCH 3/9] xfs: factor out everything but the filemap_write_and_wait from xfs_file_fsync, Christoph Hellwig |
| Next by Thread: | [PATCH 2/9] ext4: honor the O_SYNC flag for aysnchronous direct I/O requests, Darrick J. Wong |
| Indexes: | [Date] [Thread] [Top] [All Lists] |