xfs
[Top] [All Lists]

Re: REVIEW: improve/fix/update zeroing garbage in superblock sectors in

To: "Barry Naujok" <bnaujok@xxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Subject: Re: REVIEW: improve/fix/update zeroing garbage in superblock sectors in xfs_repair
From: "Barry Naujok" <bnaujok@xxxxxxx>
Date: Thu, 27 Mar 2008 16:28:19 +1100
In-reply-to: <op.t8ntcvc23jf8g2@pc-bnaujok.melbourne.sgi.com>
Organization: SGI
References: <op.t8ntcvc23jf8g2@pc-bnaujok.melbourne.sgi.com>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Opera Mail/9.24 (Win32)
Hmm... a "cd" line appeared in the patch, delete it if trying to apply
the patch.

I've attached it to be sure :)

On Thu, 27 Mar 2008 16:25:33 +1100, Barry Naujok <bnaujok@xxxxxxx> wrote:

Running XFS QA with a standard HDD with the bad_features2 problem
happening and doing "mkfs.xfs -l version=1", a problem was encounter
where it went to zero the "bad" features2 bit.

Why didn't this happen all the time?

Upon investigation, I updated the behaviour of the "secondary_sb_wack"
function. Now it always zeroes any garbage found beyond the expected
end of the xfs_sb_t structure in the first sector.

Further down in discrete field checking, there were a lot of
"  if (sb->sb_versionnum & XR_PART_SECSB_VNMASK || !do_bzero)  { "
checks which seems superfluous for the tests and operations
being performed.

The following patch relies on the bad_features2 patch from the
other week.

--

Attachment: update_sb_whack.patch
Description: Text Data

<Prev in Thread] Current Thread [Next in Thread>