xfs
[Top] [All Lists]

Re: [REVIEW] fix mkfs.xfs agcount between 64 and 128MB

To: "Niv Sardi" <xaiki@xxxxxxxxxxxxx>
Subject: Re: [REVIEW] fix mkfs.xfs agcount between 64 and 128MB
From: "Barry Naujok" <bnaujok@xxxxxxx>
Date: Mon, 25 Feb 2008 15:44:52 +1100
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
In-reply-to: <ncc8x19y8ca.fsf@sgi.com>
Organization: SGI
References: <op.t61916fp3jf8g2@pc-bnaujok.melbourne.sgi.com> <ncc8x19y8ca.fsf@sgi.com>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Opera Mail/9.24 (Win32)
On Mon, 25 Feb 2008 15:21:25 +1100, Niv Sardi <xaiki@xxxxxxxxxxxxx> wrote:


What's wrong with this:


diff --git a/xfsprogs/mkfs/xfs_mkfs.c b/xfsprogs/mkfs/xfs_mkfs.c
index e15d667..13884f9 100644
--- a/xfsprogs/mkfs/xfs_mkfs.c
+++ b/xfsprogs/mkfs/xfs_mkfs.c
@@ -422,7 +422,7 @@ calc_default_ag_geometry(
                count = 1;
                goto done;
        } else if (dblocks < MEGABYTES(128, blocklog)) {
-               blocks = MEGABYTES(16, blocklog);
+               blocks = MEGABYTES(32, blocklog);
                goto done;
        }

And what happens between 16 and 32MB?


<Prev in Thread] Current Thread [Next in Thread>