Re: [REVIEW] Refactor xfs_repair's process_dinode_int

["Barry Naujok" <bnaujok@xxxxxxx>]

On Wed, 16 Jan 2008 11:51:21 +1100, Barry Naujok <bnaujok@xxxxxxx> wrote:

> On Wed, 16 Jan 2008 07:33:29 +1100, Chandan Talukdar <chandan@xxxxxxxxx>  
> wrote:
>
> > Hi Barry,
> >
> > - In process_dinode_int(), we should be checking for 'dblkmap' not  
> > being NULL before freeing it.  There are a few error conditions which  
> > can cause the control to go to 'clear_bad_out' with dblkmap being NULL.
>
> freeing a NULL is valid

My bad! Yes, blkmap_free() doesn't check for a NULL pointer before going
through the structure. I'll fix this up.

Regards,
Barry.