David Chinner <dgc@xxxxxxx> writes:
> Increase the maximum log size supported by mkfs.
>
> The log size can be increased easily in mkfs by changing a few
> defines and a couple of types to allow the log size to increase to
> 1GB. Theoretically, the log size can be made much, much larger than
> this (up to 2^32 sectors), but going beyond 2^30 *bytes* causes
> integer overflow issues in the kernel log code.
>
> e.g. a 2GB log (2^31 bytes) will not mount because the
> space calculations in the kernel use "int" types and
> overflow:
>
> STATIC int
> xlog_space_left(xlog_t *log, int cycle, int bytes)
>
> Hence logs larger than 2^30 will not work without kernel
> modifications. Therefore this change is limited to increasing the
> log size to what we can currently support in kernel space with
> needing kernel modifications.
I'm glad you got time to get around this, I didn't include it in the
first batch as I was told it 'broke things'.
Looks good to me.
Cheers,
--
Niv Sardi
|