xfs
[Top] [All Lists]

Re: [PATCH] xfs_quota: fix missing break after foreign_allowed option

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH] xfs_quota: fix missing break after foreign_allowed option
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 26 Aug 2016 07:31:55 -0500
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1472200206-15728-1-git-send-email-zlang@xxxxxxxxxx>
References: <1472200206-15728-1-git-send-email-zlang@xxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
On 8/26/16 3:30 AM, Zorro Lang wrote:
> New quota "-f" has been brought in by:
> 
>   29647c8 xfs_quota: add capabilities for use on non-XFS filesystems
> 
> But Coverity Scan find a missing break in quota/init.c: init()
> function.
> 
> Signed-off-by: Zorro Lang <zlang@xxxxxxxxxx>

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

> ---
>  quota/init.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/quota/init.c b/quota/init.c
> index 44be322..2c18c8b 100644
> --- a/quota/init.c
> +++ b/quota/init.c
> @@ -153,6 +153,7 @@ init(
>                       break;
>               case 'f':
>                       foreign_allowed = true;
> +                     break;
>               case 't':
>                       mtab_file = optarg;
>                       break;
> 

<Prev in Thread] Current Thread [Next in Thread>