| To: | Dave Chinner <david@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx> |
|---|---|
| Subject: | [PATCH] xfs: clear PF_NOFREEZE for xfsaild kthread |
| From: | Jiri Kosina <jikos@xxxxxxxxxx> |
| Date: | Mon, 26 Oct 2015 15:53:40 +0900 (KST) |
| Cc: | xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| User-agent: | Alpine 2.00 (LNX 1167 2008-08-23) |
From: Jiri Kosina <jkosina@xxxxxxx>
Since xfsaild has been converted to kthread in 0030807c, it calls
try_to_freeze() during every AIL push iteration. It however doesn't set
itself as freezable, and therefore this try_to_freeze() will never do
anything.
Before (hopefully eventually) kthread freezing gets converted to fileystem
freezing, we'd rather mark xfsaild freezable (as it can generate I/O
during suspend).
Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>
---
fs/xfs/xfs_trans_ail.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c
index 1098cf4..06d1a29 100644
--- a/fs/xfs/xfs_trans_ail.c
+++ b/fs/xfs/xfs_trans_ail.c
@@ -497,6 +497,7 @@ xfsaild(
long tout = 0; /* milliseconds */
current->flags |= PF_MEMALLOC;
+ set_freezable();
while (!kthread_should_stop()) {
if (tout && tout <= 20)
--
Jiri Kosina
SUSE Labs
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfs: optimise away log forces on timestamp updates for fdatasync, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH] xfs: optimise away log forces on timestamp updates for fdatasync, Brian Foster |
| Previous by Thread: | The most hot sale iphone ipad imac Macbook, Miya |
| Next by Thread: | Re: [PATCH] xfs: clear PF_NOFREEZE for xfsaild kthread, Brian Foster |
| Indexes: | [Date] [Thread] [Top] [All Lists] |