Re: [PATCH] xfstests: fix 251's cp -axT problem

[Lukas Czerner <lczerner@xxxxxxxxxx>]

On Wed, 11 Jan 2012, Christoph Hellwig wrote:

> On Tue, Jan 10, 2012 at 07:39:20PM +0800, Liu Bo wrote:
> > When I ran xfstests, 251 got failed cause "cp -axT" did not work as wish:
> > cp: cannot overwrite directory `/mnt/scratch/1' with non-directory
> > 
> > With this patch, 251 has passed.
> 
> Why would cp give that message with a missing /?
> 
> I'm not against putting this in, but I'd like to understand what's going
> on.
> 
> Lukas, any idea?
> 

Hi Christoph,

the only reason I can think of is probably that Liu is accessing the
xfstests directory via symbolic link, hence the '$content' addresses the
symbolic link and cp is trying to overwrite the directory with
non-directory (symlink).

The fix is fine for both cases (xfstests as symlink and directory), confirmed
with a simple test.

Thanks!
-Lukas