On Tue, 11 Dec 2007, Bhagi rathi wrote:
On Dec 11, 2007 5:08 PM, Matthew Hodgson <matthew@xxxxxxxxxxxxx> wrote:
Hi all,
I'm experimenting with using XFS with a network block device (DST), and
have come up against the problem that when writing data to the network,
it uses kernel_sendpage to hand the page presented at the BIO layer to
the network stack. It then completes the block IO request.
Actually, you can pass a sendpage read actor which takes a reference on
the page which ensures valid page exists with you.
Hmm, i'm a little confused as to how one would do that - I can see that
sendfile can be passed a read actor for use in the underlying read, but I
can't see anywhere where sendpage can be used with a read actor. I see
that nfsd/vfs.c:nfsd_read_actor() adjusts the page refcounting to stop
them being freed before they are sent - but that only seems to be usable
when sending with sendfile.
As long as you have
ref on the page and no truncate to the same file, you can safely access
the file. Once NIC sends the data over wire, you can do put_page. This
should work.
I'm not sure that it will help, though. The problem seems to be that XFS
itself overwrites the page with new data (rather than the page being freed
and reused) whilst the page is waiting to be sent in the TCP stack. Is
there any way to prevent XFS from doing this - or have I misunderstood the
problem?
Along similar lines, is there any way to stop XFS from passing slab pages
to the block IO layer? Attempts to pass slab pages over to the TCP stack
fail too.
thanks,
Matthew.
|