xfs
[Top] [All Lists]

[PATCH] XFS: Delete duplicate macro definitions.

To: xfs@xxxxxxxxxxx
Subject: [PATCH] XFS: Delete duplicate macro definitions.
From: "Robert P. J. Day" <rpjday@xxxxxxxxxxxxxx>
Date: Fri, 14 Sep 2007 08:53:20 -0400 (EDT)
Sender: xfs-bounce@xxxxxxxxxxx
Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>

---

  something that popped out of a script i have that scans for
redundant macro definitions.  apply or not as you see fit.  not
compile-tested as it was just done visually.

diff --git a/fs/xfs/xfs_bmap_btree.h b/fs/xfs/xfs_bmap_btree.h
index a77b1b7..0173575 100644
--- a/fs/xfs/xfs_bmap_btree.h
+++ b/fs/xfs/xfs_bmap_btree.h
@@ -47,28 +47,25 @@ typedef struct xfs_bmdr_block {
  *  l1:0-20 are blockcount.
  */

+#define BMBT_TOTAL_BITLEN      128     /* 128 bits, 16 bytes */
+#define BMBT_EXNTFLAG_BITLEN   1
+#define BMBT_STARTOFF_BITLEN   54
+#define BMBT_STARTBLOCK_BITLEN 52
+
 #ifndef XFS_NATIVE_HOST

-#define BMBT_TOTAL_BITLEN      128     /* 128 bits, 16 bytes */
 #define BMBT_EXNTFLAG_BITOFF   0
-#define BMBT_EXNTFLAG_BITLEN   1
 #define BMBT_STARTOFF_BITOFF   (BMBT_EXNTFLAG_BITOFF + BMBT_EXNTFLAG_BITLEN)
-#define BMBT_STARTOFF_BITLEN   54
 #define BMBT_STARTBLOCK_BITOFF (BMBT_STARTOFF_BITOFF + BMBT_STARTOFF_BITLEN)
-#define BMBT_STARTBLOCK_BITLEN 52
 #define BMBT_BLOCKCOUNT_BITOFF \
        (BMBT_STARTBLOCK_BITOFF + BMBT_STARTBLOCK_BITLEN)
 #define BMBT_BLOCKCOUNT_BITLEN (BMBT_TOTAL_BITLEN - BMBT_BLOCKCOUNT_BITOFF)

 #else

-#define BMBT_TOTAL_BITLEN      128     /* 128 bits, 16 bytes */
 #define BMBT_EXNTFLAG_BITOFF   63
-#define BMBT_EXNTFLAG_BITLEN   1
 #define BMBT_STARTOFF_BITOFF   (BMBT_EXNTFLAG_BITOFF - BMBT_STARTOFF_BITLEN)
-#define BMBT_STARTOFF_BITLEN   54
 #define BMBT_STARTBLOCK_BITOFF 85 /* 128 - 43 (other 9 is in first word) */
-#define BMBT_STARTBLOCK_BITLEN 52
 #define BMBT_BLOCKCOUNT_BITOFF 64 /* Start of second 64 bit container */
 #define BMBT_BLOCKCOUNT_BITLEN 21

-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================


<Prev in Thread] Current Thread [Next in Thread>