Re: corruption bug in 2.6.17

[Justin Piszcz <jpiszcz@xxxxxxxxxxxxxxx>]

On Wed, 6 Jun 2007, Nathan Scott wrote:

> On Tue, 2007-06-05 at 22:24 +0200, Christian Kujau wrote:
> > ...
> >   2) generate some IO on the xfs-mounted partition...and wait until
> > the
> >      fs shut down.
>
> The problem was actually related to a particular form of btree
> dir2 transition - so, certain combinations of file names in a
> relatively large directory with size changes would trigger it.
>
> "generate some IO" is a bit too vague to be helpful.
>
> cheers.
>
> --
> Nathan

The patch that fixed it:

--- linux-2.6.17.6.orig/fs/xfs/xfs_dir2_node.c
+++ linux-2.6.17.6/fs/xfs/xfs_dir2_node.c
@@ -970,7 +970,7 @@ xfs_dir2_leafn_remove(
                        /*
                         * One less used entry in the free table.
                         */
-                       free->hdr.nused = cpu_to_be32(-1);
+                       be32_add(&free->hdr.nused, -1);
                        xfs_dir2_free_log_header(tp, fbp);
                        /*
                         * If this was the last entry in the table, we can