xfs
[Top] [All Lists]

Re: Parenthesize macros in xfs

To: Andreas Schwab <schwab@xxxxxxx>
Subject: Re: Parenthesize macros in xfs
From: Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx>
Date: Sun, 26 Mar 2006 00:23:47 +0100 (MET)
Cc: Nathan Scott <nathans@xxxxxxx>, linux-xfs@xxxxxxxxxxx, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <je1wwq2lqn.fsf@sykes.suse.de>
References: <Pine.LNX.4.61.0603202207310.20060@yvahk01.tjqt.qr> <20060321082327.B653275@wobbly.melbourne.sgi.com> <Pine.LNX.4.61.0603202239110.11933@yvahk01.tjqt.qr> <20060321084619.E653275@wobbly.melbourne.sgi.com> <Pine.LNX.4.61.0603252232570.18484@yvahk01.tjqt.qr> <je1wwq2lqn.fsf@sykes.suse.de>
Sender: linux-xfs-bounce@xxxxxxxxxxx
>> -#define swap(a, b)                                  \
>> +#define swap(a, b) do {                                     \
>>      if (swaptype == 0) {                            \
>>              long t = *(long *)(a);                  \
>>              *(long *)(a) = *(long *)(b);            \
>>              *(long *)(b) = t;                       \
>>      } else                                          \
>> -            swapfunc(a, b, es, swaptype)
>> +            swapfunc(a, b, es, swaptype)            \
>> +} while(0)
>                                           ^^
>Missing semicolon.
>

It was missing before too. ;)


Jan Engelhardt
-- 


<Prev in Thread] Current Thread [Next in Thread>